worker: add no-worker-extension-check option#39785
Closed
Ayase-252 wants to merge 3 commits intonodejs:masterfrom
Closed
worker: add no-worker-extension-check option#39785Ayase-252 wants to merge 3 commits intonodejs:masterfrom
no-worker-extension-check option#39785Ayase-252 wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
Member
|
can we just remove the check altogether? |
Member
Author
|
@devsnek of course can. opening an alternative PR. |
Member
Author
|
Alternative opened on #39788 |
Member
Author
|
Closing in favor of #39788 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
no-work-extension-checkCLI option to disable file extension check when starting a worker.Fixes: #39124
cc @addaleax